Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manifests may contain multiple digest algorithms #1228

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Manifests may contain multiple digest algorithms #1228

merged 1 commit into from
Jan 9, 2025
+1 −0

Conversation

sudo-bmitch
Copy link
Contributor

Fixes #874.

rchincha
rchincha approved these changes Dec 19, 2024
View reviewed changes
Copy link

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

sajayantony
sajayantony approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@sajayantony sajayantony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder how many registries might fail the conformance if we mixed digest algorithms.
/LGTM

@sudo-bmitch sudo-bmitch merged commit f272635 into opencontainers:main Jan 9, 2025
4 checks passed
@sudo-bmitch sudo-bmitch deleted the pr-mixed-digest-algo branch January 9, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchincha rchincha rchincha approved these changes

@sajayantony sajayantony sajayantony approved these changes

@tianon tianon tianon approved these changes

@jonjohnsonjr jonjohnsonjr Awaiting requested review from jonjohnsonjr jonjohnsonjr is a code owner

@stevvooe stevvooe Awaiting requested review from stevvooe stevvooe is a code owner

@cyphar cyphar Awaiting requested review from cyphar cyphar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify Mixing and Matching Digest types
4 participants
@sudo-bmitch @tianon @sajayantony @rchincha